Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add workflow for ci/cd #5

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

dongsam
Copy link
Member

@dongsam dongsam commented Jul 20, 2023

Description

  • build - checking build completed with no errors on PR
  • test / codecov - checking test coverage for each commit on PR
  • lint (TBD)
  • sims (TBD)
  • CodeQL (TBD)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dongsam dongsam marked this pull request as ready for review July 20, 2023 04:10
@dongsam dongsam requested review from zsystm and poorphd July 20, 2023 04:10
@dongsam dongsam mentioned this pull request Jul 20, 2023
19 tasks
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dongsam dongsam merged commit ef3e686 into liquidstaking-module Jul 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants